Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Marigold snapshot JSON from
charts/tezos/values.yaml
. Was:Now:
By default, it will no longer attempt to download a snapshot and the chain will sync from scratch. However, users can still set any JSON URL (if available) and this update shouldn't break existing configurations.
To use a specific snapshot URL such as one from tzinit.org, users can set one of:
This also allows them to use their closest region. This seems preferable to adding further options or automatically downloading a snapshot without the user requesting it, but I recommend a review to ensure there aren't unintended consequences.
Note that the
test/charts/*expect.yaml
files are sensitive to whitespace changes incharts/tezos/values.yaml
.Other minor updates:
mkchain/tqchain/mkchain.py
charts/snapshotEngine/README.md